-
Notifications
You must be signed in to change notification settings - Fork 105
feat(coder-labs/modules/codex): add support for aibridge #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Atif Ali <atif@coder.com>
…o 35C4n0r/feat-codex-aibridge
|
I'm not familiar with modules/templates enough to confidently review this but from my shallow understanding it looks good, codex config changes look good. |
|
I will go ahead and give this a test today but everything looks good after looking through this again. |
|
@DevelopmentCats I am confused by these 3 suggestions, can you please help to clarify them ?
Do we do this in any other module ? What is the purpose of this ?
Setting |
This is directly from the docker tasks template from the registry. Essentially this is the documented way of setting this module to only be enabled when run from the tasks ui. Although it has changed a bit this is what I was referencing so you are probably fine here. |
Yeah, that would make sense for the Docker template, but if we do that in agent specific module then it would just be a normal workspace (when not created as tasks). Great, Ig then no more changes are needed here, I have updated the readme, @matifali would you like to give the Readme a quick review ? I have tried to keep it in the same format as that of claude-code. |
You are all good from my perspective then here 😸 |
Version Bump RequiredOne or more modules in this PR need their versions updated. To fix this:
The CI will automatically re-run once you push the updated versions. |
|
@matifali wait, I think I marked the wrong version int he Readme. Let me fix that. |
|
@35C4n0r is it ready to merge? |
Version Bump RequiredOne or more modules in this PR need their versions updated. To fix this:
The CI will automatically re-run once you push the updated versions. |
Yes. |
|
@35C4n0r, can you fix the version issue and then merge and release? Also mention that it requires Coder version 2.30+ in the AI Bridge section. Thanks. |
Description
Type of Change
Module Information
Path:
registry/coder-labs/modules/codexNew version:
v4.1.0Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun fmt)Related Issues
Closes: #650